间隔重复插件obsidian-spaced-repetition-recall 分享

osrr · 2024 年9 月 22 日 04:32

你可以再试试提pr
现在原插件又多了一个比较活跃的开发者
应该会快一些了

github.com/st3v3nmw/obsidian-spaced-repetition

feat: refactor code to support diff methods of storing the scheduling info, and diff SR algorithms

st3v3nmw:master ← ronzulu:feat-878-support-multiple-schedule-methods

opened 07:47AM - 25 Jun 24 UTC

ronzulu

+3445 -1293

Hey there, finally have implemented and tested these non-trivial changes - and i…s now ready for review and beta testing. https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/878 From the user perspective, there shouldn't be any functional change. But the architecture has changed as follows: # Code Changes ### Algorithms The code for implementing the current algorithm has been extracted from the various files and placed in a new class `SrsAlgorithm_Osr` that implements a new interface `ISrsAlgorithm`. Future algorithms would similarly need to implement the interface `ISrsAlgorithm`. ### Data Stores The existing code for saving the scheduling info (both for notes in the frontmatter, as well as the HTML comments for the flashcards) have been placed in a new class `DataStore_StoreInNote` that implements a new interface `IDataStore`. Methods for storing the schedule info in alternate ways would similarly need to implement the `IDataStore` interface. ### DataStoreAlgorithm Although most of the existing code could be classified either algorithm or data store, some good not. This code was specific to the algorithm and data store combination. That code was extracted and placed in a new class `DataStoreInNote_AlgorithmOsr` that implements the new interface `IDataStoreAlgorithm` ### Separation Of Core Logic From User Interface Code https://github.com/st3v3nmw/obsidian-spaced-repetition/pull/751 (about 9 months ago) separated out much business logic from user interface code. Similar change was required in order to achieve the above. ### Unit testing With more code separated from UI code, it was possible to include more unit test cases. About 30 more test cases were written. # Next Steps [ [FEAT] user defined "Easy, Good, Hard" values instead of or in addition to the algorithm defined one. #741 ](https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/741) - Suggestion by @danhje as an easy way to further test these changes [ [FEAT] Stop using YAML; Move plugin info and data to separate file #162 ](https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/162) - Possibly necessary for supporting algorithms that require the storage of extensive scheduling info [ [FEAT] sm-2 is outdated, can you please replace it with the fsrs algorithm? #748 ](https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/748) # Beta testing (help wanted!) As you can appreciate, lots of work went into this. And even though more test cases were written, it's more than likely I inadvertently broke something (e.g. in functionality that I don't use myself). [main_878A.zip](https://github.com/user-attachments/files/15966849/main_878A.zip) @st3v3nmw would be great if you could have a look